fix: replace hardcoded kb_env defaults with settings.KB_ENV#14
Merged
VibhavSetlur merged 1 commit intodevelopfrom Feb 21, 2026
Merged
fix: replace hardcoded kb_env defaults with settings.KB_ENV#14VibhavSetlur merged 1 commit intodevelopfrom
VibhavSetlur merged 1 commit intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces hardcoded "appdev" defaults with the centralized configuration value settings.KB_ENV throughout the codebase. This improves flexibility by allowing the default KBase environment to be configured via environment variables rather than being hardcoded.
Changes:
- Updated function parameter defaults in
workspace.pyto usesettings.KB_ENVinstead of "appdev" - Updated FastAPI Query parameter defaults in
routes.pyto usesettings.KB_ENVand enhanced examples to include both "appdev" and "prod" - Updated Pydantic Field default in
models.pyto usesettings.KB_ENVand added necessary import
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/utils/workspace.py | Updated 7 function signatures to use settings.KB_ENV as the default for kb_env parameters |
| app/routes.py | Updated 6 FastAPI endpoint Query parameters to use settings.KB_ENV as default and improved examples; also updated getattr fallback logic |
| app/models.py | Updated TableDataRequest model Field default to use settings.KB_ENV and added import for settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.